[BB pr#1] KIT-1 Git msg hooks & basic build configuration

[coveobot]

Pull request 🔀 created by @ThibodeauJF on 2020-04-01 15:45
Last updated on 2020-04-01 22:14
Original Bitbucket pull request id: 1

Participants:

• @btaillon (reviewer)
• @olamothe (reviewer) ✔️
• @samisayegh (reviewer) ✔️
• @ThibodeauJF

Source: Commit 6834ee008835 on branch KIT-1> Destination: https://bitbucket.org/coveord/ui-kit/commits/b244fe702d8e on branch master
Merge commit: https://github.com/None/commit/3e6d468fd902

State: MERGED

• https://coveord.atlassian.net/browse/KIT-1

‌

[coveobot]

@olamothe commented on 2020-04-01 15:46

Outdated location: line 2 of .deployment.config.json

I’d remove coveo

[coveobot]

@olamothe commented on 2020-04-01 15:47

Location: line 29 of .deployment.config.json

That’s not true :slight_smile: Was configuring snyk complicated ? Normally, if there’s a package.json at the top of the repo I think it should all be automatic in dep pipeline. Was that not the case ?

[coveobot]

@olamothe commented on 2020-04-01 15:48

Location: line 32 of .deployment.config.json

We’ll also need to configure veracode eventually. So I have the same question as above, is it complicated to setup/will be done later ?

[coveobot]

@olamothe commented on 2020-04-01 15:49

Location: line 18 of package.json

Those changes did not affect the lock files ? 🤔

[coveobot]

@olamothe commented on 2020-04-01 15:51

Location: line 7 of package.json

What does --stream do ?

[coveobot]

@olamothe approved ✔️ the pull request on 2020-04-01 15:52

[coveobot]

@ThibodeauJF commented on 2020-04-01 15:54

Location: line 29 of .deployment.config.json

I was going to create tasks for creating a snyk & veracode project, just didn’t want to bother with them right away

[coveobot]

@ThibodeauJF commented on 2020-04-01 15:55

Location: line 18 of package.json

Just changed the order, not the versions.

[coveobot]

@olamothe commented on 2020-04-01 15:56

Location: line 29 of .deployment.config.json

Also FYI, if you would like to test/check certifiers works properly, you can have them run in dev.

Looks like this :

"certifiers" : {
   "dev" : [
       "snyk": {....}
    ]
}

‌

[coveobot]

@ThibodeauJF commented on 2020-04-01 18:20

Location: line 7 of package.json

Stream output from child processes immediately, prefixed with the originating package name. This allows output from different packages to be interleaved.

Basically it streams the outputs live but intermingled. Instead of waiting until the build is finished to do a cleaner output.

[coveobot]

@samisayegh commented on 2020-04-01 18:45

Location: line 20 of .deployment.config.json

With this configuration, it looks like we would always push to the same latest directory. Is this temporary until we switch to a versioned approach?

[coveobot]

@samisayegh approved ✔️ the pull request on 2020-04-01 18:49

[coveobot]

@ThibodeauJF commented on 2020-04-01 20:55

Location: line 20 of .deployment.config.json

For the moment the updated master branch will be deployed to that latest folder.

We are going to have to add a versioning system in place at some point by the time to start releasing yes. For now the only environment is dev. This file is not complete.

What I could see being useful is still always to deploy the latest master branch code in dev to be easily used throughout the company (e.g. by PS)

latest could be renamed to beta or anything else…