-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atomic): added Generated Answer component #3003
Conversation
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
- Double check from @coveo/documentation or very good engrish writers for the string
- @btaillon check for the project vet check.
packages/atomic/src/components/search/atomic-generated-answer/source-citations.tsx
Fixed
Show resolved
Hide resolved
Questions: |
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/source-citations.tsx
Fixed
Show fixed
Hide fixed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this because there's a lot of duplication with the smart snippet, there's accessibility issues, and there's a vulnerability (noopener).
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.pcss
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.pcss
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.pcss
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.pcss
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/source-citations.tsx
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/typing-loader.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-generated-answer/source-citations.tsx
Outdated
Show resolved
Hide resolved
All good @btaillon, thanks for the great comments. I made multiple improvements. Please review as soon as you can. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge! We can make some improvements later
SVCC-3030
UI component to show streamed responses
Video Demo
Screen.Recording.2023-06-27.at.1.42.31.PM.mov
When the auto-retry on the stream has been reached, the component shows a retry button to the user which will re-execute the search request in its entirety to generate a completely fresh stream.