Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atomic): added Generated Answer component #3003

Merged
merged 106 commits into from
Jun 28, 2023
Merged

Conversation

nathanlb
Copy link
Contributor

@nathanlb nathanlb commented Jun 27, 2023

SVCC-3030

UI component to show streamed responses
Video Demo

Screen.Recording.2023-06-27.at.1.42.31.PM.mov

When the auto-retry on the stream has been reached, the component shows a retry button to the user which will re-execute the search request in its entirety to generate a completely fresh stream.

Screenshot 2023-06-27 at 1 44 49 PM

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 179.3 179.3 0
search 334.8 334.8 0
insight 291.3 291.3 0
product-listing 279.8 279.8 0
product-recommendation 154.6 154.6 0
recommendation 189.6 189.6 0

@nathanlb nathanlb changed the base branch from master to feat/headless-gen-answer June 27, 2023 18:28
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

  • Double check from @coveo/documentation or very good engrish writers for the string
  • @btaillon check for the project vet check.

Base automatically changed from feat/headless-gen-answer to master June 27, 2023 18:58
@lvu285
Copy link
Contributor

lvu285 commented Jun 27, 2023

Questions:
#1: Learn more section, those items are clickable? do we have tooltips for those items with long titles?
#2: What will display if there is no result returns at all?
#3: The length of the pop-up, is it fix, or adjustable or will be up-to the question generated?
#4: please make sure that if the query suggestion dropdown when search should be on top of the genQa
#5: I suggest we need to improve the message "Something's wrong" ... so people will have better understand what they should do next
#6: do we have UA for "like/dislike", click on LearnMore events?
#7: Don't forget Storybook, component should be available there

@nathanlb
Copy link
Contributor Author

nathanlb commented Jun 27, 2023

Questions: #1: Learn more section, those items are clickable? do we have tooltips for those items with long titles? #2: What will display if there is no result returns at all? #3: The length of the pop-up, is it fix, or adjustable or will be up-to the question generated? #4: please make sure that if the query suggestion dropdown when search should be on top of the genQa #5: I suggest we need to improve the message "Something's wrong" ... so people will have better understand what they should do next #6: do we have UA for "like/dislike", click on LearnMore events? #7: Don't forget Storybook, component should be available there

  1. Yes and we have the tooltips with the full titles
  2. If there is no generated answer then we don't show the component.
  3. Right now the generated answer is capped at a maximum of 256 tokens which is around 100 words. This is set on the backend.
  4. Yes the dropdown is on top
  5. Yes you're right I updated it to "Oops! Something went wrong while trying to generate an answer."
  6. We do have UA for the clicks and interactions.
  7. The component is marked as internal for now so we won't do storybook just yet.

Copy link
Contributor

@btaillon-coveo btaillon-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this because there's a lot of duplication with the smart snippet, there's accessibility issues, and there's a vulnerability (noopener).

@nathanlb nathanlb requested a review from btaillon-coveo June 27, 2023 21:16
@nathanlb
Copy link
Contributor Author

nathanlb commented Jun 28, 2023

sorry! I should've taken more time to review last time. Blocking this because there's a lot of duplication with the smart snippet, there's accessibility issues, and there's a vulnerability (noopener).

All good @btaillon, thanks for the great comments. I made multiple improvements. Please review as soon as you can. 🙏

Copy link
Contributor

@btaillon-coveo btaillon-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge! We can make some improvements later

@nathanlb nathanlb merged commit 2f2096b into master Jun 28, 2023
@nathanlb nathanlb deleted the atomic-gen-answer branch June 28, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants