[BB pr#2] KIT-3 Configure Snyk #2
Comments
So, I was wondering if we’d want to scan the root package.json file, since it only contains dev dependencies/lib that we use as “tooling” to help us develop/deploy etc. My understanding is that, with lerna, the only things that will ever be included in the top package.json file will always be “dev dependencies”. Is that a fair assumption ? And so we’d only want to scan/test the subpackages. I’ve asked in slack (#support-dev-tooling) to make sure. Edit: And in that case, can we put “packages/*” or something like that ? |
|
Yep, confirmed, we don’t need to check licenses for build tool/library only. |
|
|
…e Search Box components #2 (#3501) * created quanticSearchBoxInput with customEvents, cleaned up standalone and default searchbox * some more improvements * fixed events, styling, need to fix submit search * fix issues and clean logs * fixed e2e tests * some cleanup * added rough structure of UTs (to finish) * added unit tests, still need some work * added some improvements, some tests still failing * set custom event names to lowercase * modified events in uts * added commands for unit tests in the README file * fixed and cleanup unit tests for searchboxinput * fixed linter issue with test * try to fix linter fail * added unit tests for withoutSubmitButton * fix bug display of searchbox when expandable and withoutSubmitButton is true * fix icon sliding issue in expandable searchbox * added feedback improvements * fixed bug where pressing enter on clear button was not working for standalone searchbox * Revert "added feedback improvements" This reverts commit 965b011. * Revert "Revert "added feedback improvements"" This reverts commit 35dd5d8. * Revert "fixed bug where pressing enter on clear button was not working for standalone searchbox" This reverts commit e89a138. * refactored aria-labelledBy * removed useless aria value * added some improvements
Checkout the headless project on Snyk: https://app.snyk.io/org/coveo-jsui/
https://coveord.atlassian.net/browse/KIT-3
The text was updated successfully, but these errors were encountered: