Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(atomic): allow user to customize grid card click behavior/links #4287

Merged
merged 15 commits into from
Aug 27, 2024
Merged

feat(atomic): allow user to customize grid card click behavior/links #4287

merged 15 commits into from
Aug 27, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Aug 15, 2024 •
edited
Loading

@louis-bompart
Copy link
Collaborator Author

louis-bompart commented Aug 15, 2024 •
edited
Loading

  • add support for other item-template/item-link/*-list

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.1 0
commerce 342.6 342.7 0
search 415.6 415.7 0
insight 392.3 392.4 0
product-listing 306.4 306.4 0
product-recommendation 214.9 214.9 0
recommendation 257.2 257.3 0.1
ssr 405.6 405.7 0
ssr-commerce 353.2 353.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart marked this pull request as ready for review August 20, 2024 12:32
@louis-bompart louis-bompart requested review from a team as code owners August 20, 2024 12:32
pathiery
pathiery approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@pathiery pathiery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for atomic file

Spuffynism
Spuffynism approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Spuffynism Spuffynism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the headless commerce part

packages/headless/src/features/commerce/product-templates/product-templates-manager.ts Show resolved Hide resolved
@louis-bompart louis-bompart disabled auto-merge August 27, 2024 15:25
@louis-bompart louis-bompart merged commit e5961ca into master Aug 27, 2024
117 checks passed
@louis-bompart louis-bompart deleted the grid-link branch August 27, 2024 19:30
@louis-bompart louis-bompart mentioned this pull request Aug 29, 2024
Closed
@dguerinCoveo dguerinCoveo mentioned this pull request Oct 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 23, 2024
@dguerinCoveo @olamothe
fix(atomic): fix atomic-commerce product card click invalid selector (#…
22c2e70 
…4588)

There was a bug introduced
[here](#4287), that caused the
display Grid in IPX recs list (among others to stop working). A fix was
made [here](#4367), but this fix
does not seem to be included in the latest atomic v2 backport release.
So I'm adding it.

---------

Co-authored-by: Olivier Lamothe <[email protected]>
@dguerinCoveo dguerinCoveo mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamothe olamothe olamothe approved these changes

@Spuffynism Spuffynism Spuffynism approved these changes

@pathiery pathiery pathiery approved these changes

@mikegron mikegron Awaiting requested review from mikegron mikegron was automatically assigned from coveo/service-integrations

@dguerinCoveo dguerinCoveo Awaiting requested review from dguerinCoveo dguerinCoveo was automatically assigned from coveo/service-integrations

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme alexprudhomme is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Finale mainline v2 release
4 participants
@louis-bompart @olamothe @Spuffynism @pathiery