Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy runner may create extra python environment #30

Closed
jonapich opened this issue Apr 12, 2021 · 0 comments · Fixed by #31
Closed

mypy runner may create extra python environment #30

jonapich opened this issue Apr 12, 2021 · 0 comments · Fixed by #31
Assignees
@jonapich

Comments

@jonapich
Copy link
Collaborator

There was an issue where the environment wasn't correctly taken into account, causing an extra environment to be created.

For instance, if you installed coveo-stew in 3.9 and only had a 3.8 environment setup for a project, the mypy runner would run the 3.8 tests, then create a 3.9 environment, and run the tests again.

Now we correctly identify and activate environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonapich jonapich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#30 // Fix environments coveooss/coveo-python-oss
4 participants
@jonapich @dblanchette @klalumiere @jfsmith-at-coveo