#30 // Fix environments #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsmith-at-coveo
approved these changes
Apr 12, 2021
klalumiere
reviewed
Apr 12, 2021
|
|
||
| @contextmanager | ||
| def _activate_poetry_environment( | ||
| self, environment: PythonEnvironment = None |
There was a problem hiding this comment.
Should it be Optional[PythonEnvironment]? Actually I'm surprise that mypy doesn't complain... 🤔 Did you do some magic so that PythonEnvironment can be None?
There was a problem hiding this comment.
That's exactly that. Optional is implied when default is None. Compare with the annotation of _cached_activated_environment.
There was a problem hiding this comment.
well actually... seems like this is actually deprecated and we should start putting Optional everywhere... 😱
There was a problem hiding this comment.
There was a problem hiding this comment.
anyway, we'll do them all at the same time. no need to do this here.
klalumiere
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #30