Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status icon accessibility #12306

Closed
wants to merge 17 commits into from
Closed

Conversation

gcamacho079
Copy link
Contributor

Description

Adds a new default "Status" column to relevant tables, and updates instances of standalone status icons to use adjacent text.

This also fixes issues with the color contrast of the status icons on hover/selected/focused states because the adjacent text always meets 4.5:1 contrast.

Related issues

Resolves DEV-436, DEV-470, DEV-559
Fixes final issue in #6916

@gcamacho079 gcamacho079 requested a review from a team as a code owner November 11, 2022 23:49
@linear
Copy link

linear bot commented Nov 11, 2022

DEV-436 Status icons in element status select are not contrasted from hover/focus background

Entry and category index pages

When hovering over or focusing on options in the status select dropdown, icon color contrast against background is very low

Icon colors should turn white on hover or focus to maintain a 3:1 or greater contrast ratio against the background

Resolves CMS-107

Screen Shot 2022-04-05 at 2.48.30 PM.png

DEV-470 Element status shapes do not have an accompanying legend

.element.hasstatus

Users can turn on status shapes in order to distinguish between status in a way that doesn't depend on color vision. However, there is no accompanying legend or text that allows users to learn and understand the shapes.

Solution #1:

Status icons are always used in badges, and always have accompanying text (see this example on CodePen). This might require dropping the status below the element title on index pages and in element selection fields.

Solution #2:

Legends on all pages where status indicators exist (the legend can be hidden in an expandable region on page load). On Edit screens, the legend might exist below the meta details sidebar. On element index screens, it might be below the sources navigation.

Resolves CMS-128

DEV-559 Status indicator is difficult to see when element is selected inside Element Selector Modal

Page Area:

Element selector modal

Issue Description:

When a user has selected an element from the modal, the graphic indicating status may no longer be visible on top of the darker background

Action:

Add a border around the indicator, or add text alongside the indicator to render is decorative

Screenshot/Code Snippet:

Screen Shot 2022-04-27 at 10.02.17 AM.png

Resolves CMS-199

@gcamacho079 gcamacho079 added accessibility 👤 features related to accessibility ui 👀 features related to the control panel UI labels Nov 11, 2022
@brandonkelly brandonkelly changed the base branch from 4.4 to 5.0 January 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility ui 👀 features related to the control panel UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant