Only localized element types should get the site condition rule #12601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents. - Allows a condition like `AddressCondition` to set its default element type property without it being overridden on instantiation. - Unsets the site rule from the condition if the element type is localized - Set the default element types for user condition and address condition for now, as they are the only non localized element types.
lukeholder
changed the title
lukeholder
changed the title
lukeholder
changed the title
This was referenced Feb 1, 2023
…d-site-rule # Conflicts: # CHANGELOG.md
brandonkelly
deleted the
bugfix/unlocalized-element-types-dont-need-site-rule
branch
|
Craft 4.3.10 is out with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a condition builder with a non-localised element type, the "Site" condition rule should not be available for use.
This PR unsets the site rule from the condition if the element type is not localized