Only localized element types should get the site condition rule

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Fixed a bug where clicking on the scrollbar of a disclosure menu would close it. ([#12681](https://github.com/craftcms/cms/issues/12681))
 - Fixed a bug where large asset thumbnails weren’t centered within Assets fields. ([#12682](https://github.com/craftcms/cms/issues/12682))
 - Fixed a PHP error that could occur when versioning asset URLs. ([#12678](https://github.com/craftcms/cms/issues/12678))
+- Fixed a bug where the “Site” element condition rule was available for non-localizable element types’ conditions. ([#12601](https://github.com/craftcms/cms/pull/12601))
 
 ## 4.3.9 - 2023-02-14
 

src/elements/conditions/ElementCondition.php

@@ -103,15 +103,15 @@ protected function conditionRuleTypes(): array
             SlugConditionRule::class,
         ];
 
-        if (Craft::$app->getIsMultiSite()) {
+        /** @var string|ElementInterface|null $elementType */
+        /** @phpstan-var class-string<ElementInterface>|ElementInterface|null $elementType */
+        $elementType = $this->elementType;
+
+        if (Craft::$app->getIsMultiSite() && (!$elementType || $elementType::isLocalized())) {
             $types[] = SiteConditionRule::class;
         }
 
-        if ($this->elementType !== null) {
-            /** @var string|ElementInterface $elementType */
-            /** @phpstan-var class-string<ElementInterface>|ElementInterface $elementType */
-            $elementType = $this->elementType;
-
+        if ($elementType !== null) {
             if ($elementType::hasUris()) {
                 $types[] = HasUrlConditionRule::class;
                 $types[] = UriConditionRule::class;