Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Code does manage Deeds & UX translations (only Legal Code translations) #162

Closed
TimidRobot opened this issue Jul 26, 2021 · 0 comments · Fixed by #201
Closed

[Bug] Code does manage Deeds & UX translations (only Legal Code translations) #162

TimidRobot opened this issue Jul 26, 2021 · 0 comments · Fixed by #201
Assignees
@TimidRobot
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for work Ready for work

Comments

@TimidRobot
Copy link
Member

TimidRobot commented Jul 26, 2021 •
edited
Loading

Description

Code does manage Deeds & UX translations (only Legal Code translations)

Reproduction

licenses/transifex.py:

  • check_for_translation_updates() and check_for_translation_updates_with_repo_and_legal_codes() only check legal code resource slugs. The Deed & UX resource slug and related translations are never referenced or managed.

Expectation

Deeds & UX translations should also be managed.

Additional context
@TimidRobot TimidRobot added 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for work Ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jul 26, 2021
@TimidRobot TimidRobot self-assigned this Jul 26, 2021
@TimidRobot TimidRobot changed the title [Bug] Code does manage Deed & UX translations (only Legal Code translations) [Bug] Code does manage Deeds & UX translations (only Legal Code translations) Jul 26, 2021
TimidRobot added a commit that referenced this issue Aug 3, 2021
@TimidRobot
WORK IN PROGRESS: begin translation rewrite
822a947 
- Fix #164
  - Add settings variables and set appropriately
    - DEEDS_UX_RESOURCE_NAME = "Deeds & UX"
    - DEEDS_UX_RESOURCE_SLUG = "deeds_ux"
- Improve langauge info/support (fix #165)
  - Use Babel to populate as much info as possible
- Begin woring on #162
This was referenced Aug 3, 2021
Merged
Merged
@TimidRobot TimidRobot mentioned this issue Nov 5, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimidRobot TimidRobot

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for work Ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transifex push (code) creativecommons/cc-legal-tools-app
1 participant
@TimidRobot