-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple enhancements and fixes / Repair and speeding up Travis CI builds #168
Conversation
Travis CI failing because Laravel Dusk has old Chrome driver, according to laravel/dusk#641 issue. |
Using package https://github.com/staudenmeir/dusk-updater See laravel/dusk#641 This commit will probably fix Travis CI failing, because Travis installs latest stable Chrome which not in sync with Chrome driver shipped with Laravel Dusk
According to Travis CI logs, eacf717 commit helped with Chrome and its driver to be in sync of versions to process Dusk tests |
Caused by 87beeb The problem actually with `mix.extract()` and webpack code-splitting mechanism (chunking). Probably, this issue also causes blank page and one of many reasons why Travis CI failing tests.
Finished with this PR, so waiting for your review @cretueusebiu |
Thanks for all the great work! Will merge it soon. |
Great to hear. |
I see you added |
Yeah, probably that's not good behavior. Will try to improve the way of clean rebuilding frontend & its assets. ETA: 1 hour. |
Found bug with Laravel Mix and Webpack chunks (in |
It's really a bummer with Laravel Mix 4. There seems to be so many new bugs introduced... Should we wait a bit more for a new release of Mix or maybe go back to v2 ? |
I think we can stand with v4 by applying few codehacks for building process (fixed few already) and release new |
I made it working fine, but there's still bug with HMR mode. |
Great! HMR didn't worked before too, so that's not a problem. |
* Routes file now has less copy-pasted ugly code, and got full support of Webpack code-splitting via dynamic imports and Vue.js async components (`vue-router` uses it under the hood) * Temporary dropped support for `mix.version()` (in favor of `laravel-mix-versionhash`) due its buggy behavior while generating output Laravel Mix manifest * Better assets versioning mechanism, including dynamically imported js modules * Improved behavior of building process at production environment. Old assets removed only after compiled new ones, preventing 404 errors while Laravel Mix compiling these assets * Made HMR mode work great again (but time to time it may do full page reload)
That's it, fixed all bugs of Laravel Mix, even HMR mode 😃
|
Great job with this PR! I've made some minor changes and will tag a new release soon. |
sweetalert2
from^7.19.3
to^8.10.0
vue-router
,vue-i18n
,jquery
,sass
,eslint-plugin-import
,eslint-plugin-node
no such element: Unable to locate element
andelement not interactable
)mix.extract()
, because it's buggy with Webpack code-splitting/chunking mechanism (dynamic imports), see commit addf76d and related issue Extracted files path issue when using extract() and chunkFilename.. laravel-mix/laravel-mix#1889composer.lock
for freshness