-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chrome driver to support browser v74 #641
Comments
I'm facing the exact same issue. |
Same here. |
Same. |
same issue. |
In the meantime, you can use my updater package: https://github.com/staudenmeir/dusk-updater |
The reply is appreciated and hopefully it will help some as copying the 74.X chromedriver executable into laravel/dusk/bin will work for local dev. However it doesn't work for CI and an update to the package will be needed at some point. Which may well not happened until a 2.47 chromedriver is released that covers a few versions of Chrome. |
The ChromeDriver release strategy has changed and it looks like there will be no more releases that support multiple versions of Chrome: http://chromedriver.chromium.org/downloads/version-selection Why doesn't the updater work for CI? |
That does look like it's the case. I'd looked at that and hoped/expected that something like 2.47 might support a range of browsers when it's released, but it does look like new drivers have only been built to support specific versions and maybe a 2.47 is not in the works. Which would suggest that this package will become awkward to use in it's current state: I don't mind using the current version of a browser (though it's caught me out this time, and I think it caught me out before too - maybe I should learn from this :) but having to use the current version because Dusk can only support one version at a time in the future might not be ideal for everyone. Because of that, there may be a need to provide a number of chromedrivers in the package with an option to use any of them. It looks like the simplest solution for now is to make the correct version of the chromedriver available somewhere in your code repo and adding to DuskTestCase::prepare():
Fair enough - it will work by running the command on the CI server after the Dusk package is updated. Which is either a manual step or a change to the build file to do this as part of the build process. My first comment reflected that I prefer not to make changes to the contents of /vendor as these cannot be reflected in the project's repo where there are alternatives that can be contained within the project code. But I can see that it would work. However, I'll just go with manually setting which chromedriver to use until we get a solution from the maintainers of the repo. 'Cause using work-arounds to make up for issues in packages generally suck and get piddly to maintain. And others with the issue can chose which solution works best for them as this is all libre here :) So some official comment on what's likely to happen here would be really appreciated |
I just closed this by mistake... |
same issue. |
Please use the package from staudenmeier until we update the driver. |
Ran into this problem this morning. I can't see many options other than no longer storing the chrome driver in the package and adding a command to check for the version of chrome, downloading the right version before running dusk for the first time and keeping it under the vendor folder outside of source control. At 5mb it's not too bad to keep it in the package but if there will be a new driver for each major chrome release it might become a bit excessive to have multiple copies in the repo. |
Using package https://github.com/staudenmeir/dusk-updater See laravel/dusk#641 This commit will probably fix Travis CI failing, because Travis installs latest stable Chrome which not in sync with Chrome driver shipped with Laravel Dusk
Same problem... |
Same issue. |
The new |
I have tried
and
Anyway I got
What should I do more? P. S.
returns
|
@Tarasovych Please try terminating all running ChromeDriver processes. |
@staudenmeir that's strange, but:
returns a new one process each time, so after I found its PID and go
, it just outputs
I'm working in Homestead, tried
and relogin into VM, didn't helped |
What error do you get after |
No error. I get this:
|
When you run Dusk? |
I get this on some tests:
|
Dusk is still using the old ChromeDriver. Please try rebooting your machine (if you haven't already). |
Didn't think of that. It solved it! Thanks : ) |
Hello,
|
@ouily What exactly doesn't work? Is there an error? What OS are you using? |
My Google Chrome is up to date. Version 75.0.3770.100 (Official Build) (64-bit) Still I see this error message:
|
@SnehalYeole Is there a specific reason why you are using Selenium? Dusk works without it. |
I am developing some front end tests using java and selenium. |
I think I am looking for an answer at wrong place. I am not using Dusk. |
thank you @staudenmeir i've used successfully the package https://github.com/staudenmeir/dusk-updater |
php artisan dusk:update --detect When I try to update to 87, it will have errors |
@staudenmeir Yes, It looks don't need to update. But when I run php artisan dusk, it will have errors under below. Facebook\WebDriver\Exception\SessionNotCreatedException: session not created |
@ramseyjiang If you are using the right ChromeDriver, this must be an issue with Chrome or ChromeDriver. Can you reproduce the issue on a fresh Laravel installation using the |
@staudenmeir I have done it. I have several laravel environments. You know, before chrome 87, everyone php artisan dusk is ok, no errors. But after chrome 87 auto update, then no one can pass dusk test. The same error happens. I cannot update chrome driver to 87, it always 68. It looks chrome 68 can be ok for every chrome 76 version, but for 87, it doesn't work. Please help me. Thank you |
Pure laravel, only install dusk, but it still has the error. @staudenmeir Tests\Browser\ExampleTest::testBasicExample |
I can't reproduce this. We'll have to wait and see if other people report the same issue. |
@staudenmeir If you upgrade your chrome to 76.0.3809.87, do you still not see the same issue? I think this issue happened because chrome driver was used in dusk it couldn't upgrade to 76.0.3809.87. I found 76.0.3809.68.zip on the official website, but I cannot find 76.0.3809.87.zip. But my chrome is 76.0.3809.87 version. |
No, it works for me. There is no ChromeDriver 76.0.3809.87. Only the first three parts of the version number match: http://chromedriver.chromium.org/downloads/version-selection |
@staudenmeir Yes, I know it doesn't have ChromeDriver 76.0.3809.87. But mine still have that issue. |
it says that it needs version 76, but that is clearly what is already installed. is there an issue with minor versions not matching? if yes the error should definitely say what it needs. or some other issue? Also, maybe this issue should be reopened? |
@l0rb You are using ChromeDriver 76 and this version only works with Chrome 76. You need to update your browser. |
I'm going to lock this issue as this has become a dumping ground for support. Please use a support channel if you have further issues with the chrome driver. The most common use cases have all been covered in this thread. Make sure:
|
Description:
Chrome 74 is now available. The current driver has not been updated for 4 months and supports Chrome 70-73 only.
(Driver info: chromedriver=2.45.615279 (12b89733300bd268cff3b78fc76cb8f3a7cc44e5),platform=Linux 4.15.0-47-generic x86_64)
Facebook\WebDriver\Exception\SessionNotCreatedException: session not created: Chrome version must be between 70 and 73
However...chromedriver 74.X does not explicitly support older versions:
https://chromedriver.storage.googleapis.com/74.0.3729.6/notes.txt
Compared to 2.45.X which clearly supports a range of versions 70-73 (and 2.46) but not 74:
https://chromedriver.storage.googleapis.com/2.45/notes.txt
https://chromedriver.storage.googleapis.com/2.46/notes.txt
Does this mean we have to wait for a version that has a more encompassing support so we don't lose backwards compatibility? So we're either pinning Chrome to 73 or using a standalone driver rather than the packaged driver?
Cheers.
The text was updated successfully, but these errors were encountered: