-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
channel: ready::fairness2 test is racy #477
Comments
Hmm yeah that definitely looks like a fluke - statistically speaking, the test is bound to fail :) (but we hope so rarely it never actually fails). I think bumping the threshold should do the trick. |
I tried changing the assertion to assert!(hits.iter().all(|x| x.get() > 0)); And unfortunately even that sometimes fails. I guess we'd have to increase the count? |
I opened #495 with the updated assertion and an increased |
In practice servers will occasionally become unreachable and trying to allocate to them will fail. Rather than leaking capacity in this case we remove the job on allocation failure. Fixes crossbeam-rs#477
The test occasionally fails in CI and locally.
Reproduce by running:
$ for (( i=1 ;; i+=1 )); do echo "*** test $i ***"; cargo test --test ready fairness || break; done
To quote @cuviper:
The text was updated successfully, but these errors were encountered: