-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax racy fairness test #495
Conversation
This looks good to me, but seems like CI is broken. I'm inclined to merge anyway and take care of that later... |
It seems due to signal-hook's MSRV was increased to 1.31: vorner/signal-hook@e63edcf |
So we need to either:
|
One upside of the latter is that it would also mean #487 no longer needs to bump the MSRV. But that's definitely minor. |
I have tried the first way (downgrade deps) locally, but it seems that the MSRV of so many dependencies is actually increasing, so this seems to be difficult... |
One issue here is that the docs say:
That is a very strict policy. The policy should (probably) instead be "six months" or something? But as it stands, we'd need to issue new major releases of all the crossbeam crates to do that... It also definitely gets weird since people will have to run through all sorts of hoops to actually get it running with 1.28 — so are we even really supporting MSRV 1.28? |
I agree with the current policy needs to be changed as suggested in #444 (comment).
I mentioned this in #428 (comment), but I think it is ok to set MSRV based on the compilable version (without downgrading the dependencies). |
Let's merge and fix CI in a follow-up PR. |
Fixes #477