-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatter crash when heredoc contains string interpolations and do-end block #9473
Labels
Comments
Mmh, #9362 redux? /cc @makenowjust :) |
jhass
added
kind:bug
A bug in the code. Does not apply to documentation, specs, etc.
topic:tools:formatter
labels
Jun 13, 2020
puts <<-FOO
foo
#{1}
FOO The second (or more) line interpolation inside no indent heredoc causes this bug. |
makenowjust
added a commit
to makenowjust/crystal
that referenced
this issue
Jun 13, 2020
Fixed crystal-lang#9473 It is important to simplify the formatter implementation.
paulcsmith
added a commit
to luckyframework/lucky
that referenced
this issue
Jun 16, 2020
paulcsmith
added a commit
to luckyframework/lucky
that referenced
this issue
Jun 16, 2020
* Use Socket::Address instead of String for Request#remove_address * Use Process#signal * Fix specs due to Log::Severity::Warn rename * Use ::Log::Metadata * Fixes due to Log::Severity::Warn rename * Use Log::Entry#data as local_context * Use compress/gzip * Use Log::Entry#data as local_context * Socket::Address * Refactor due to Log::Metadata / Log::Metadata::Value split * Update shards * Use latest Dexter * Use Crystal 0.35.0 * Remove unused Habitat setting * Use more specific rescue clause Using a generic rescue can hide other legitimate errors. Let's use a more specific one to catch just the socket error * Reformat helpful_error to avoid bug in Crystal crystal-lang/crystal#9473 Co-authored-by: Brian J. Cardiff <[email protected]>
paulcsmith
added a commit
to luckyframework/lucky
that referenced
this issue
Jun 16, 2020
* Use Socket::Address instead of String for Request#remove_address * Use Process#signal * Fix specs due to Log::Severity::Warn rename * Use ::Log::Metadata * Fixes due to Log::Severity::Warn rename * Use Log::Entry#data as local_context * Use compress/gzip * Use Log::Entry#data as local_context * Socket::Address * Refactor due to Log::Metadata / Log::Metadata::Value split * Update shards * Use latest Dexter * Use Crystal 0.35.0 * Remove unused Habitat setting * Use more specific rescue clause Using a generic rescue can hide other legitimate errors. Let's use a more specific one to catch just the socket error * Reformat helpful_error to avoid bug in Crystal crystal-lang/crystal#9473 Co-authored-by: Brian J. Cardiff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Error was happened when I formatted a heredoc that contains do-end block and Interpolation.
It works if there are not interpolations in do-end block.
embedder.cr
Backtrace
Crystal Version
System
The text was updated successfully, but these errors were encountered: