Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: apply string pieces combination even if heredoc has no indent #9475

Merged

Conversation

makenowjust
Copy link
Contributor

Fixed #9473

It is important to simplify the formatter implementation.

Fixed crystal-lang#9473

It is important to simplify the formatter implementation.
@jhass jhass added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Jun 13, 2020
@jhass jhass requested a review from a team August 25, 2020 08:15
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jhass jhass added the pr:ready-to-merge The changes are good to go, we need to triage merging it. label Aug 25, 2020
@asterite asterite added this to the 1.0.0 milestone Sep 5, 2020
@asterite asterite merged commit 52c750e into crystal-lang:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. pr:ready-to-merge The changes are good to go, we need to triage merging it. topic:tools:formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatter crash when heredoc contains string interpolations and do-end block
3 participants