Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support named arguments in macro methods #8429

Merged
merged 5 commits into from
Nov 15, 2019
Merged

Support named arguments in macro methods #8429

merged 5 commits into from
Nov 15, 2019

Conversation

Blacksmoke16
Copy link
Member

Fixes #8291

@Blacksmoke16 Blacksmoke16 mentioned this pull request Nov 9, 2019
Closed
straight-shoota
straight-shoota reviewed Nov 12, 2019
View reviewed changes
src/compiler/crystal/macros/interpreter.cr Outdated Show resolved Hide resolved
src/compiler/crystal/macros/methods.cr Outdated Show resolved Hide resolved
src/compiler/crystal/macros/methods.cr Show resolved Hide resolved
@Blacksmoke16
Copy link
Member Author

This should be good now @straight-shoota

@asterite asterite added this to the 0.32.0 milestone Nov 15, 2019
@asterite asterite merged commit 4559cd6 into crystal-lang:master Nov 15, 2019
@Blacksmoke16 Blacksmoke16 deleted the stringliteral-camelcase branch November 15, 2019 18:19
@straight-shoota straight-shoota mentioned this pull request Nov 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:lang:macros topic:stdlib:macros
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.

StringLiteral.camelcase does not handle (lower: true) parameter
3 participants
@Blacksmoke16 @asterite @straight-shoota