Type node#name without generic args #8458
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #8429. Will make this a draft until thats merged, then can rebase.
This PR allows getting the name of a
TypeNode
without the type's type vars. The main use case for this is when iterating over the subclasses of a parent type, where the children have type vars, and you're wanting to include data from a macro or annotation as generic type arguments. Currently since the type vars were always included you couldn't just do like{{"#{type.name}(#{ann[:theType]})".id}}
since that would expand to saySomeType(T)(Foo)
. This allows skipping the(T)
to make supplying the generic types easier.See https://github.com/Blacksmoke16/assert/blob/master/src/assert.cr#L152 where I have to
gsub
the type arguments away before adding my own.