Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIURL not parsed in parseConfig of appprovider #991

Closed
individual-it opened this issue Jul 23, 2020 · 0 comments · Fixed by #1035
Closed

UIURL not parsed in parseConfig of appprovider #991

individual-it opened this issue Jul 23, 2020 · 0 comments · Fixed by #1035

Comments

@individual-it
Copy link
Contributor

individual-it commented Jul 23, 2020 •
edited
Loading

found the issue while doing some simple unit tests, see #992
glpatcern added a commit to glpatcern/reva that referenced this issue Jul 29, 2020
@glpatcern
Removed storageID and UIURL from config.
f35b85c 
StorageID is auto-resolved in the gateway service, whereas
the UIURL's doc was misleading: we need to decide whether
to drop it entirely (surely it won't stay in the config).

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Jul 29, 2020
@glpatcern
Removed storageID and UIURL from config.
4dd4086 
StorageID is auto-resolved in the gateway service, whereas
the UIURL's doc was misleading: we need to decide whether
to drop it entirely (surely it won't stay in the config).

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Jul 29, 2020
@glpatcern
Removed storageID and UIURL from config.
c64497c 
StorageID is auto-resolved in the gateway service, whereas
the UIURL's doc was misleading: we need to decide whether
to drop it entirely (surely it won't stay in the config).

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Jul 29, 2020
@glpatcern
Removed storageID and UIURL from config.
4b9bded 
StorageID is auto-resolved in the gateway service, whereas
the UIURL's doc was misleading: we need to decide whether
to drop it entirely (surely it won't stay in the config).

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Jul 30, 2020
@glpatcern
Removed storageID and UIURL from config.
09c3951 
StorageID is auto-resolved in the gateway service, whereas
the UIURL's doc was misleading: we need to decide whether
to drop it entirely (surely it won't stay in the config).

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
@glpatcern glpatcern mentioned this issue Jul 30, 2020
Merged
glpatcern added a commit to glpatcern/reva that referenced this issue Jul 30, 2020
@glpatcern
Refactored the OpenFileInAppProvider workflow
28d8d82 
This included changing the gRPC protocol and removing
storageID and UIURL from config.

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Jul 30, 2020
@glpatcern
Removed storageID and UIURL from config.
a42b54a 
StorageID is auto-resolved in the gateway service, whereas
the UIURL's doc was misleading: we need to decide whether
to drop it entirely (surely it won't stay in the config).

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Jul 31, 2020
@glpatcern
Refactored the OpenFileInAppProvider workflow
c06ae21 
This included changing the gRPC protocol and removing
storageID and UIURL from config.

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Aug 3, 2020
@glpatcern
Removed storageID and UIURL from config.
00c1501 
StorageID is auto-resolved in the gateway service, whereas
the UIURL's doc was misleading: we need to decide whether
to drop it entirely (surely it won't stay in the config).

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Aug 3, 2020
@glpatcern
Refactored the OpenFileInAppProvider workflow
7b49633 
This included changing the gRPC protocol and removing
storageID and UIURL from config.

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Aug 3, 2020
@glpatcern
Refactored the OpenFileInAppProvider workflow
0741172 
This included changing the gRPC protocol and removing
storageID and UIURL from config.

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit to glpatcern/reva that referenced this issue Aug 4, 2020
@glpatcern
Refactored the OpenFileInAppProvider workflow
90b0ba2 
This included changing the gRPC protocol and removing
storageID and UIURL from config.

En passant, this fixes cs3org#991 and includes other minor changes
concerning error handling and logging.
glpatcern added a commit that referenced this issue Aug 4, 2020
@glpatcern
Refactor AppProvider workflow and protocol (#1035)
95e8788 
* Refactored the OpenFileInAppProvider workflow

This included changing the gRPC protocol and removing
storageID and UIURL from config.

En passant, this fixes #991 and includes other minor changes
concerning error handling and logging.

* Linting and other fixes + changelog

* Added configuration for ODF and MD files

* Fixed error handling + improved logging of a stack trace

* Further fixes following tests

* Improved URL handling following review

Also cleared some TODOs and reduced HTTP timeout to 5s

* Refactored the /wopi/cbox/endpoints HTTP call

This is now in its own function, as it does not need to be executed
at each incoming request. Added a TODO for implementing a refresh
every day or so.

* Do not use for now a shared map.

TODO for a future PR: refresh the map of apps URLs every day or week,
and cache it at the service level (protected by a multi-reader Lock).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor AppProvider workflow and protocol glpatcern/reva
1 participant
@individual-it