Refactor AppProvider workflow and protocol #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@glpatcern cs3apis merged, remember changelog |
|
@glpatcern looks already pretty good |
glpatcern
changed the title
glpatcern
force-pushed
the
appprovider-fixes
branch
2 times, most recently
from
7d4baf2 to
9592157
Compare
glpatcern
changed the title
glpatcern
force-pushed
the
appprovider-fixes
branch
4 times, most recently
from
612baf8 to
fc72ce3
Compare
glpatcern
changed the title
glpatcern
force-pushed
the
appprovider-fixes
branch
from
fc72ce3 to
f2cd667
Compare
ishank011
reviewed
Aug 3, 2020
glpatcern
force-pushed
the
appprovider-fixes
branch
from
78c2b14 to
498b612
Compare
5 tasks
ishank011
reviewed
Aug 4, 2020
This included changing the gRPC protocol and removing storageID and UIURL from config. En passant, this fixes cs3org#991 and includes other minor changes concerning error handling and logging.
Also cleared some TODOs and reduced HTTP timeout to 5s
This is now in its own function, as it does not need to be executed at each incoming request. Added a TODO for implementing a refresh every day or so.
glpatcern
force-pushed
the
appprovider-fixes
branch
from
8d2ffa9 to
d4d4d35
Compare
TODO for a future PR: refresh the map of apps URLs every day or week, and cache it at the service level (protected by a multi-reader Lock).
glpatcern
force-pushed
the
appprovider-fixes
branch
from
d4d4d35 to
454d635
Compare
labkode
reviewed
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses cs3org/cs3apis#85 to implement a simpler protocol from the client to the Reva gateway, and a more enriched one from the gateway to the appprovider. For now, WOPI is still the only "driver" implementing the appprovider logic.
Also,
storageIDandUIURLare removed from the app-provider's config:StorageIDis auto-resolved in the gateway service, whereas theUIURL's doc was misleading: we need to decide whether to drop it entirely (and surely it won't stay in the config).En passant, this fixes #991 and includes a few other changes and fixes concerning error handling, logging and documentation.