Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro ocdav #2665

Merged
merged 18 commits into from
Apr 11, 2022
Merged

Micro ocdav #2665

merged 18 commits into from
Apr 11, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Mar 22, 2022

This PR adds a new pkg/micro package that exposes the internal ocdav http handler as a go micro service. For testing pkg/micro/ocdav/cmd/main.go can start the service standalone.

  • add auth, ctx, log, middlewares
  • add tracing middleware
  • add more config options

@update-docs
Copy link

update-docs bot commented Mar 22, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic force-pushed the micro-ocdav branch 3 times, most recently from 8c0972d to 4c61dfd Compare March 22, 2022 19:24
@butonic butonic requested a review from wkloucek March 22, 2022 19:24
This was referenced Mar 24, 2022
butonic added 4 commits March 24, 2022 13:05
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic marked this pull request as ready for review March 24, 2022 13:26
@butonic butonic requested review from a team, labkode, ishank011 and glpatcern as code owners March 24, 2022 13:26
@butonic butonic marked this pull request as draft March 24, 2022 13:26
butonic added 2 commits March 25, 2022 14:38
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@kobergj
Copy link
Contributor

kobergj commented Apr 11, 2022

@wkloucek could you check tracing commit?

@butonic butonic marked this pull request as ready for review April 11, 2022 12:19
Signed-off-by: jkoberg <[email protected]>
Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good IMO. It only adds a new way of starting the ocdav service whithout changing existing behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants