-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use embeddable ocdav go micro service #3397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled... |
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
butonic
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
April 11, 2022 08:43
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
C0rby
reviewed
Apr 12, 2022
Signed-off-by: jkoberg <[email protected]>
C0rby
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Apr 12, 2022
Author: Jörn Friedrich Dreyer <[email protected]> Date: Tue Apr 12 11:27:24 2022 +0200 Use embeddable ocdav go micro service (#3397) * allow proxy to route to micro service Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * use go micre ocdav service instead of reva frontend Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * add missing gateway default config Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * update reva branch for testing Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * add changelog Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * add missing comands Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * bump reva version Signed-off-by: jkoberg <[email protected]> * tidy Signed-off-by: jkoberg <[email protected]> * bump reva again Signed-off-by: jkoberg <[email protected]> * a blind mans config change Signed-off-by: jkoberg <[email protected]> * add ocdav to must start extensions Signed-off-by: jkoberg <[email protected]> * fail when neither backend nor service is set Signed-off-by: jkoberg <[email protected]> Co-authored-by: jkoberg <[email protected]>
dragonchaser
pushed a commit
that referenced
this pull request
Apr 13, 2022
* allow proxy to route to micro service Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * use go micre ocdav service instead of reva frontend Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * add missing gateway default config Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * update reva branch for testing Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * add changelog Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * add missing comands Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * bump reva version Signed-off-by: jkoberg <[email protected]> * tidy Signed-off-by: jkoberg <[email protected]> * bump reva again Signed-off-by: jkoberg <[email protected]> * a blind mans config change Signed-off-by: jkoberg <[email protected]> * add ocdav to must start extensions Signed-off-by: jkoberg <[email protected]> * fail when neither backend nor service is set Signed-off-by: jkoberg <[email protected]> Co-authored-by: jkoberg <[email protected]>
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use the reva
pgk/micro/ocdav
package that implements a go micro compatible version of the ocdav service.Requires cs3org/reva#2665 and uses a replace until it is merged.
next steps I do not see as part of this PR: