Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use embeddable ocdav go micro service #3397

Merged
merged 18 commits into from
Apr 12, 2022
Merged

Use embeddable ocdav go micro service #3397

merged 18 commits into from
Apr 12, 2022

Conversation

butonic
Copy link
Member

@butonic butonic commented Mar 25, 2022

We now use the reva pgk/micro/ocdav package that implements a go micro compatible version of the ocdav service.

Requires cs3org/reva#2665 and uses a replace until it is merged.

next steps I do not see as part of this PR:

  • extract ocdav into a dedicated extension
  • make all debug endpoints use micro http service and discover them via the micro registry

butonic added 4 commits March 25, 2022 15:46
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@update-docs
Copy link

update-docs bot commented Mar 25, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

butonic added 2 commits March 25, 2022 16:09
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@ownclouders
Copy link
Contributor

ownclouders commented Mar 25, 2022

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
proxy/pkg/proxy/proxy.go Outdated Show resolved Hide resolved
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

10.3% 10.3% Coverage
16.2% 16.2% Duplication

@kobergj kobergj merged commit 0e88cb1 into master Apr 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the micro-ocdav branch April 12, 2022 09:27
ownclouders pushed a commit that referenced this pull request Apr 12, 2022
Author: Jörn Friedrich Dreyer <[email protected]>
Date:   Tue Apr 12 11:27:24 2022 +0200

    Use embeddable ocdav go micro service (#3397)

    * allow proxy to route to micro service

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * use go micre ocdav service instead of reva frontend

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * add missing gateway default config

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * update reva branch for testing

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * add changelog

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * add missing comands

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * bump reva version

    Signed-off-by: jkoberg <[email protected]>

    * tidy

    Signed-off-by: jkoberg <[email protected]>

    * bump reva again

    Signed-off-by: jkoberg <[email protected]>

    * a blind mans config change

    Signed-off-by: jkoberg <[email protected]>

    * add ocdav to must start extensions

    Signed-off-by: jkoberg <[email protected]>

    * fail when neither backend nor service is set

    Signed-off-by: jkoberg <[email protected]>

    Co-authored-by: jkoberg <[email protected]>
dragonchaser pushed a commit that referenced this pull request Apr 13, 2022
* allow proxy to route to micro service

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

* use go micre ocdav service instead of reva frontend

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

* add missing gateway default config

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

* update reva branch for testing

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

* add changelog

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

* add missing comands

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

* bump reva version

Signed-off-by: jkoberg <[email protected]>

* tidy

Signed-off-by: jkoberg <[email protected]>

* bump reva again

Signed-off-by: jkoberg <[email protected]>

* a blind mans config change

Signed-off-by: jkoberg <[email protected]>

* add ocdav to must start extensions

Signed-off-by: jkoberg <[email protected]>

* fail when neither backend nor service is set

Signed-off-by: jkoberg <[email protected]>

Co-authored-by: jkoberg <[email protected]>
@micbar micbar mentioned this pull request Nov 25, 2022
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants