Fix nested resource check for publicly shared space root #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of some duplication by moving the isSpaceRoot function to the utils package.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
rhafer
changed the title
rhafer
requested review from
butonic,
dragonchaser and
kobergj
and removed request for
a team,
labkode and
glpatcern
kobergj
requested changes
Apr 16, 2024
kobergj
approved these changes
Apr 16, 2024
The 'Path' returned as part of the ResourceInfo from a Stat call might be relative. So we need to Use 'GetPath()' to lookup the full path of the parent. Otherwise the simple 'HasPrefix' check for whether a file a ancestor might fail. Co-Authored-By: Christian Richter <[email protected]>
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Apr 16, 2024
rhafer
added a commit
to owncloud/ocis
that referenced
this pull request
Apr 16, 2024
ownclouders
pushed a commit
to owncloud/ocis
that referenced
this pull request
Apr 16, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dragonchaser