allow named oob messages in ocap mode #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of switching on opts.ocap_mode, switch on the type of the wrapped payload's first element: 1. if it's a string, check if on_oob_message supplied. if so, call it with the usual function(error, result) callback. NOTE: the signature was the opposite before, function(message, error), so this is a breaking change! but (error, result) is the standard asynchronous javascript signature, so i think this is correct. 2. if it's a function, make sure we are in ocap mode. if so, call the function exactly as before. 3. if it's anything else, report "Unknown oob message type".
gordonwoodhull
added a commit
to att/rcloud
that referenced
this pull request
Jan 20, 2015
- enable the feature in rserve.conf - add handler for on_oob_message - add new (empty) block of message handlers in session.js - include refactor of oob message code in cscheid/rserve-js#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rserve now supports direct input through the oob message "console.in". However, rserve.js disables named oob messages when in
ocap_mode.This PR is an attempt to fix that. I still want to test it further, but I thought I would open the PR now to make sure I am not breaking the design of rserve.js somehow.
+@s-u
Details below from commit message:
instead of switching on opts.ocap_mode, switch on the type of the wrapped
payload's first element:
with the usual function(error, result) callback.
NOTE: the signature was the opposite before, function(message, error),
so this is a breaking change! but (error, result) is the standard
asynchronous javascript signature, so i think this is correct.
exactly as before.