Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation failure: The “type” attribute for the “style” element is not needed and should be omitted #724

Closed
mikkopori opened this issue Jun 10, 2018 · 5 comments
Labels
complexity:low You can fix it, c'mon! enhancement No kittens die if we don't do that.

Comments

@mikkopori
Copy link

Hello,

testing my application with a validator I ran into these warnings:

The “type” attribute for the “style” element is not needed and should be omitted

for example in

<style type="text/css" data-jss="" data-meta="MuiToolbar"> .. </style>

Since I noticed that validation errors were reported here earlier I thought I should report this as well. Did not find any mention of this particular warning.

:)

@kof
Copy link
Member

kof commented Jun 10, 2018

didn't know adding optional type attribtute is an antipattern now

@kof kof added enhancement No kittens die if we don't do that. complexity:low You can fix it, c'mon! labels Jun 10, 2018
@oliviertassinari
Copy link
Contributor

oliviertassinari commented Jun 10, 2018

You can reproduce the warning on your documentation website with https://validator.w3.org/:

capture d ecran 2018-06-10 a 13 09 20

@oliviertassinari
Copy link
Contributor

oliviertassinari commented Jun 10, 2018

It should be as simple as removing this line:

this.element.type = 'text/css'

Then, maybe updating the tests and updating the docs.
@mikkopori Do you want to work on it?

@mikkopori
Copy link
Author

It would be fair since I reported this :)

Never worked on this before, but I guess I'll learn quick. It will take a couple of days before I have time to look into this, so if anyone is faster feel free.

@kof
Copy link
Member

kof commented Jun 19, 2018

released 9.8.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:low You can fix it, c'mon! enhancement No kittens die if we don't do that.
Projects
None yet
Development

No branches or pull requests

3 participants