Add option to remove "type" attribute #366 #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ovidijusr thanks, can you describe use case? |
|
Well personally, I would set not having a "type" tag as default behaviour. Because w3c markup validator gives warnings about that type. But this is breaking tests and i'm not sure if that won't affect something else. TLDR; if you use w3c - disabling type attribute helps to solve w3c warnings |
|
@ovidijusr what about remove this by default? |
|
@evilebottnawi Sure, should i update PR? |
|
@ovidijusr yep, let's do it |
|
Close in favor #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #366