Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Outcome Result Groups IDs #1206

Merged
merged 15 commits into from
Aug 15, 2024
Merged

Fix Outcome Result Groups IDs #1206

merged 15 commits into from
Aug 15, 2024

Conversation

akabishau
Copy link
Collaborator

@akabishau akabishau commented Aug 1, 2024 •
edited
Loading

Included in this PR:

  • updated mapping for Outcome related models
  • updated mapping for Result Group model
  • added functionality to Result Group than handles result_group_id after all mappings are processed
  • updated tests for affected models

Resolves #1209

@akabishau akabishau changed the base branch from refactor-updater-logic to dev August 2, 2024 14:49
@akabishau akabishau changed the base branch from dev to refactor-updater-logic August 2, 2024 15:00
@akabishau akabishau changed the base branch from refactor-updater-logic to dev August 2, 2024 15:09
@akabishau akabishau changed the title TEMP PR FOR REVIEW Fix Outcome Result Groups IDs Aug 8, 2024
@akabishau akabishau requested a review from micronix August 8, 2024 19:21
@akabishau akabishau self-assigned this Aug 10, 2024
micronix
micronix requested changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@micronix micronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

@akabishau akabishau requested a review from micronix August 15, 2024 13:34
@akabishau akabishau merged commit 46fc0a9 into dev Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micronix micronix Awaiting requested review from micronix

Assignees

@akabishau akabishau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

result_group_id is incorrect in some trials
2 participants
@akabishau @micronix