tag-expressions: Remove deprecated method use_2to3

[krisgesling]

Summary

Removes the call to use_2to3 in setup.py as this method has been deprecated in setuptools>=58.0.0 (see changelog).

Fixes #1736

Details

The standard library module lib2to3 is deprecated and will be removed in Python 3.10.

Further details about why this was deprecated can be found here:
pypa/setuptools#2086

Motivation and Context

Installation of cucumber-tag-expressions will fail if the system is using newer versions of setuptools. This is actively occuring on Github Actions.

How Has This Been Tested?

pip install setuptools>=58.0.0
pip install cucumber-tag-expressions

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

I haven't tested on Python2 and am not familiar with the details of use_2to3 so this may be a breaking change.

Checklist:

• The change has been ported to Java.
• The change has been ported to Ruby.
• The change has been ported to JavaScript.
• The change has been ported to Go.
• The change has been ported to .NET.
• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have updated the CHANGELOG accordingly.

[graingert]

You'll need to apply 2to3 to the source code and set a python_requires >= '3.6'

[aurelien-reeves]

Great, thank you!

[graingert]

you'll need to apply lib2to3 to the source code for your package to support py3

Comments from @graingert

[graingert]

you could alternatively use https://github.com/PyCQA/modernize to keep python2 support

[graingert]

actually it looks like 2to3 was redundant in this project:

diff --git a/tag-expressions/python/cucumber_tag_expressions/__init__.py b/tag-expressions/python/cucumber_tag_expressions/__init__.py
index 45b88a343..0877fdfc4 100644
--- a/tag-expressions/python/cucumber_tag_expressions/__init__.py
+++ b/tag-expressions/python/cucumber_tag_expressions/__init__.py
@@ -13,7 +13,7 @@ Theses selected items are normally included in a test run.
 .. _`behave: Gherkin`: https://behave.readthedocs.io/en/latest/philosophy.html#the-gherkin-language
 """
 
-from __future__ import absolute_import
+
 from .parser import parse, TagExpressionParser, TagExpressionError
 
 __version__ = "1.1.2"
diff --git a/tag-expressions/python/cucumber_tag_expressions/parser.py b/tag-expressions/python/cucumber_tag_expressions/parser.py
index 792c065ad..71aba994b 100644
--- a/tag-expressions/python/cucumber_tag_expressions/parser.py
+++ b/tag-expressions/python/cucumber_tag_expressions/parser.py
@@ -14,7 +14,7 @@ UNSUPPORTED:
 * Support special tags w/ escaped-parens: ``@reqid\\(10\\)``
 """
 
-from __future__ import absolute_import
+
 from enum import Enum
 from cucumber_tag_expressions.model import Literal, And, Or, Not, True_
 
@@ -154,7 +154,7 @@ class TagExpressionParser(object):
     """
     # pylint: disable=too-few-public-methods
     TOKEN_MAP = {token.keyword: token
-                 for token in Token.__members__.values()}
+                 for token in list(Token.__members__.values())}
 
     @classmethod
     def select_token(cls, text):

[aurelien-reeves]

@krisgesling @graingert thanks a lot folks! 🤩

For the moment, we do not have much python contributors to the cucumber projects. So, thank you very much for your contribution!

If you still have the possibility to submit other contribution, feel free to do so 😅

We have a dedicated slack workspace. Again, feel free to join! You can register then head over to #intro.

Finally, note that there is an Open Collective for Cucumber. You can be pay for your contributions!

[aslakhellesoy]

Hi @krisgesling,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[krisgesling]

Thanks @aslakhellesoy - this is a great welcome message for new contributors!

I very much appreciate the great package you and the team have built too.