Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber docs #36

Closed
wants to merge 23 commits into from
Closed

Cucumber docs #36

wants to merge 23 commits into from

Conversation

gmk1217
Copy link
Contributor

@gmk1217 gmk1217 commented Jul 8, 2016

Added Introduction to BDD and Bdd with cucumber . Updated Summary.md for the link "Introduction to BDD"

@jbpros
Copy link
Member

jbpros commented Jul 8, 2016

Thanks, this is nice!

If you preview the introduction you've written, you'll see all the text is currently considered code blocks. That's because 4-spaces indentation makes the text a code block. Can you fix that?

A smaller issue: we've decided to use British English and I spotted "Behaviour" spelled inconsistently.

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 8, 2016

is it in Quote??

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 8, 2016

Modified as suggested, Please let me know if any corrections are needed.

@@ -37,7 +37,7 @@
* [Organising Step Definitions](#)
* [Programming](#)
* [Modelling by Example](#)
* [Test-Driven Development](#)
* [Test-Driven Development](docs/Intro-tdd.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use lower-case-hyphenated-file-names

* It lets your teammates count on you, and you on them.
* It feels good to write it.

But how do we get to clean code that works? Many forces drive us away from clean code,and even from code that works. Without taking too much counsel of our fears, here's what we do: we drive development with automated tests, a style of development called Test Driven Development (TDD).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One space after comma

@mattwynne
Copy link
Member

Some of this writing is great @gmk1217! I hope you don't mind me asking, but Is this all your own original work?

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 23, 2016

It's mix and match @mattwynne...:)

@mattwynne
Copy link
Member

Can you be specific about which bits you've written and which bits are taken from other sources @gmk1217? And can you add references where you've quoted other sources? It's not going to be OK to just take other people's content and add it here as though it was our own. Somebody will get upset with us, and rightly so IMO.

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 26, 2016

@mattwynne I added references at the end of the doc. I dont want their credit either.. :)

@aslakhellesoy
Copy link
Contributor

Somebody will get upset with us, and rightly so IMO.

We'd also be in breach of their license if it requires explicit copying of their license (For example, the MIT license requires a copy).

In the worst case we'd be infringing copyright as I already explained in #39.

@aslakhellesoy
Copy link
Contributor

Hmm - looks like this PR has the same copyright problems as #39. We can't merge this until those images are removed.

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 26, 2016

@aslakhellesoy As per your suggestion i deleted and cleared mess in #40

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants