Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified docs as per suggestions and cleared the mess #40

Closed
wants to merge 11 commits into from

Conversation

gmk1217
Copy link
Contributor

@gmk1217 gmk1217 commented Jul 13, 2016

Modified documents as per suggested changes added cucumber.md and living documentation.md

@gmk1217 gmk1217 mentioned this pull request Jul 26, 2016
aslakhellesoy added a commit that referenced this pull request Jul 26, 2016
@aslakhellesoy
Copy link
Contributor

Are you creating a new PR every time you are making a modification? Please don't do that - just push new commits to the existing PR. You have 4 open pull requests now - #36, #38, #39, #40, and there seems to be dependencies and duplication between them. This makes it too hard for us to approve your pull requests.

  • Each pull request should not modify several (unrelated) documents.
  • The title of each pull request should explain what document you're adding/changing.

Have a read through the contribution guidelines again please.

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 26, 2016

@aslakhellesoy : yeah i messed up and confused every i created a pull request. My sincere apologies for creating a mess.
Now I am clear and wouldnt repeat it again... :)

@aslakhellesoy
Copy link
Contributor

No worries @gmk1217 - we're very grateful for your help! Maybe it's best if you close all your existing pull requests and submit new ones, where each PR is for one document? And none of the PRs depend on other PRs?

I'm still concerned about copying content from other sites. All our content should be original.

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 26, 2016

ok will close duplicate PRs .
Hmm its not mandatory to have those paragrahs there, since they added value to the doc, I added them ... still if you guys have concern on those i will delete them..

@mattwynne
Copy link
Member

Thanks for working with us on this @gmk1217. In general, small PRs are better - when there's less to consider and discuss, they'll flow through the review process faster.

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 27, 2016

Agreed. Will adopt and make thngs easy for you guys.

@gmk1217 gmk1217 closed this Aug 1, 2016
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants