pkg/tool/exec: add .Default() to struct env value #1787
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Mårtensson <[email protected]>
addreas
force-pushed
the
exec-run-env-default
branch
from
b0c4e9d to
1a23806
Compare
|
Thank you for contributing, and apologies that we hadn't replied yet :) Per the contributing docs, if this is meant to fix a bug, please raise an issue following the bug template first. That way we can be sure that we're on the same page and can reproduce the issue before we consider a fix. |
|
I've left the code that required this behind so I would be more likely to close this PR than create a bug report. The test change should demonstrate the motivation for this, though. |
|
Thanks - now imported to Gerrit as https://review.gerrithub.io/c/cue-lang/cue/+/1174128. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered an error that was quite confusing:
invalid environment variable value "perfectly-reasonable-string", looking into what caused that I ended up with this little diff.