pkg/tool/exec: handle default value references in exec.Run environment variables #2764
Conversation
| MESSAGE: #message | ||
| SENDER: *"John Doe" | string | ||
| } | ||
| } |
There was a problem hiding this comment.
Let me know if there's any concerns with the testing here 🙂 . I noticed an issue with how lists are handled (I think) and opened #2763, so I didn't include a test here for the list variation of env currently.
nickfiggins
changed the title
…t variables Currently, environment variables used in exec.Run which contain references to default values results in an error when evaluating. This fixes the handling of default values in exec.Run to ensure that environment variables which reference them are populated correctly. Fixes cue-lang#2572. Signed-off-by: Nick Figgins <[email protected]>
nickfiggins
force-pushed
the
env-defaults
branch
from
ff9ba8b to
ffcb9ac
Compare
nickfiggins
changed the title
|
Thank you! This appears to be a duplicate of #1787, but you correctly spotted that this mistake appears on lists as well, and your tests are more extensive, so I think we should merge this PR :) |
Abandoned It turns out that an issue was filed for this half a year ago (#2572) and #2764 was just sent as an alternative PR, which also fixes this for lists and has more tests, so I'll go with that one assuming it's okay with you. Thank you for contributing nonetheless! Patch-set: 1 Status: abandoned Tag: autogenerated:gerrit:abandon Attention: {"person_ident":"Gerrit User 1017723 \u003c1017723@d5d70762-12d0-45a1-890d-524b12d3f735\u003e","operation":"REMOVE","reason":"Change was abandoned"}
There was a problem hiding this comment.
Thank you! Imported to Gerrit as https://review.gerrithub.io/c/cue-lang/cue/+/1174339
If you want to make more contributions, I'd recommend doing so on Gerrit directly, so that we can avoid this indirection and extra steps :) https://github.com/cue-lang/cue/blob/master/CONTRIBUTING.md#preparing-for-gerrithub-cl-contributions
|
I also used a slightly shorter commit message title, but otherwise the commit is unchanged. |
Ah got it, thanks! I'll try and use Gerrit next time 🙂 |
Currently, environment variables used in exec.Run which contain references to default values results in an error when evaluating.
This fixes the handling of default values in exec.Run to ensure that environment variables which reference them are populated correctly.
Fixes #2572.