Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide meaningful error messages on authn JWT failures #169

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

matthiasjung
Copy link
Contributor

@matthiasjung matthiasjung commented Mar 10, 2023

Desired Outcome

Replace current error message:
Unable to unmarshal token : unexpected end of JSON input
with:
./summon-conjur abc/def
ERROR Failed creating a Conjur client: 401 Unauthorized.

Implemented Changes

Minor update to file client.go checking HTTP Error code.

Connected Issue/Story

No issue reported so far.

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

matthiasjung and others added 2 commits March 10, 2023 10:42
Update with changed from latest CyberArk
   "Unable to unmarshal token : unexpected end of JSON input"
@matthiasjung matthiasjung requested a review from a team as a code owner March 10, 2023 12:44
@szh szh self-assigned this Mar 10, 2023
@szh
Copy link
Contributor

szh commented Mar 10, 2023

Thank you for the contribution @matthiasjung! I've gone ahead and added some tests and a changelog entry. Please let me know if it looks good to you and we'll get this merged.

@matthiasjung
Copy link
Contributor Author

Hi @szh, thanks for enhancing changelog and adding tests cases!
Looks good now. Please go ahead.

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for the PR!

@szh szh merged commit 3fb0b50 into cyberark:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants