Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test due to different error message on CI #170

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix failing test due to different error message on CI #170

merged 1 commit into from
Mar 21, 2023

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 10, 2023

Desired Outcome

Follow up to #169. Fixes test that succeeds locally but fails on CI due to a different error message (different wording presumably comes from OS differences).

Implemented Changes

Remove the assert.ErrorContains line added in #169

@szh szh requested a review from a team as a code owner March 10, 2023 15:45
@szh szh self-assigned this Mar 10, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 10, 2023

Code Climate has analyzed commit 29975b6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.4%.

View more on Code Climate.

@szh szh requested a review from doodlesbykumbi March 14, 2023 13:17
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@szh szh merged commit 06f2fb7 into main Mar 21, 2023
@szh szh deleted the fix-test branch March 21, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants