Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource_exists method #32

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Add resource_exists method #32

merged 1 commit into from
Aug 2, 2022

Conversation

szh
Copy link
Contributor

@szh szh commented Aug 2, 2022

Desired Outcome

Add method to check whether a resource exists. Mimics what existed in the Ruby API.

Implemented Changes

  • Added a resource_exists method to the Client and Api classes which invokes the resources/{account}/{kind}/{identifier} url on the Conjur server and checks the status code for 404 vs 200/403.

Connected Issue/Story

Supports CyberArk internal issue: ONYX-23083

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Aug 2, 2022
@szh szh force-pushed the add-resource-exists branch 2 times, most recently from d060023 to 20c3414 Compare August 2, 2022 15:57
@szh szh marked this pull request as ready for review August 2, 2022 19:44
@szh szh requested a review from a team as a code owner August 2, 2022 19:44
@szh szh force-pushed the add-resource-exists branch from 20c3414 to aaa54d1 Compare August 2, 2022 19:47
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@szh szh merged commit a86483b into main Aug 2, 2022
@szh szh deleted the add-resource-exists branch August 2, 2022 19:59
@szh szh mentioned this pull request Aug 10, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants