Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Add resource exists command #418

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add resource exists command #418

merged 1 commit into from
Aug 4, 2022

Conversation

szh
Copy link
Contributor

@szh szh commented Aug 2, 2022

Depends on cyberark/conjur-api-python#32

Desired Outcome

Add the Resource command and exists subcommand which existed in the Ruby CLI but was not added to the Python CLI.

Implemented Changes

Added support for command with syntax conjur resource exists -i user:someuser

Connected Issue/Story

CyberArk internal issue link: ONYX-23083

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: ONYX-22999
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Aug 2, 2022
@szh szh force-pushed the resource-exists-command branch 4 times, most recently from 8cb63c7 to 2127bd0 Compare August 3, 2022 16:10
@szh szh marked this pull request as ready for review August 3, 2022 18:31
@szh szh requested a review from a team as a code owner August 3, 2022 18:31
gl-johnson
gl-johnson previously approved these changes Aug 3, 2022
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small suggestion, feel free to take or leave it.

conjur/controller/resource_controller.py Outdated Show resolved Hide resolved
@szh szh force-pushed the resource-exists-command branch 2 times, most recently from d799e5f to a56222c Compare August 3, 2022 20:38
@szh szh requested a review from gl-johnson August 3, 2022 20:38
gl-johnson
gl-johnson previously approved these changes Aug 3, 2022
@szh szh force-pushed the resource-exists-command branch from a56222c to d88a977 Compare August 3, 2022 20:45
@szh szh requested a review from gl-johnson August 3, 2022 20:46
@szh szh merged commit 70aa928 into main Aug 4, 2022
@szh szh deleted the resource-exists-command branch August 4, 2022 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants