Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment scripts include support for Secrets Provider standalone app container #292

Closed
diverdane opened this issue May 3, 2021 · 0 comments · Fixed by #380
Closed

Comments

@diverdane
Copy link
Contributor

diverdane commented May 3, 2021

Is your feature request related to a problem? Please describe.

This issue incrementally adds support for a standalone Secrets Provider "app" container into the scripts that were created with Issue #239.

*** NOTE: This issue covers only modification to the app deploy scripts. It does not include Helm chart implementation for deploying an app that can use the Secrets Provider running in standalone "app" mode. That Helm chart implementation is covered by Issue #273. It's entirely possible that it's easier to handle both this issue (Issue #292) and the Helm implementation (Issue #273) with a single PR.***

Out of Scope

Describe the solution you would like

App deploy scripts include Helm install of a Secrets Provider running in

Describe alternatives you have considered

Additional context

DoD

-[ ] App deploy script is modified to use the existing Secrets Provider Helm chart to deploy SP running as a standalone "app" container
-[ ] App deploy script is modified to use Helm chart created with Issue #273 to deploy a sample app + Summon that can use the SP running as a standalong "app" container
-[ ] Scripts are tested in a Kubernetes cluster, Secrets Provider mutates Kubernetes Secrets
-[ ] Pet Store application can use mutated Kubernetes Secrets access its database.

diverdane pushed a commit that referenced this issue Aug 16, 2021
This change adds the deployment of an application that uses the Secrets
Provider in standalone mode to the E2E application deployment scripts.

This change depends upon PR #373 merging, since PR #373 adds a Helm
subchart for an application that uses Secrets Provider in standalone
mode. There is one line in the `start` script that will need to be
changed after PR #373 has merged in order to enable deployment of
this application.

Addresses Issue #292
diverdane pushed a commit that referenced this issue Aug 16, 2021
This change adds the deployment of an application that uses the Secrets
Provider in standalone mode to the E2E application deployment scripts.

This change depends upon PR #373 merging, since PR #373 adds a Helm
subchart for an application that uses Secrets Provider in standalone
mode. There is one line in the `start` script that will need to be
changed after PR #373 has merged in order to enable deployment of
this application.

Addresses Issue #292
diverdane pushed a commit that referenced this issue Aug 17, 2021
This change adds the deployment of an application that uses the Secrets
Provider in standalone mode to the E2E application deployment scripts.

This change depends upon PR #373 merging, since PR #373 adds a Helm
subchart for an application that uses Secrets Provider in standalone
mode. There is one line in the `start` script that will need to be
changed after PR #373 has merged in order to enable deployment of
this application.

Addresses Issue #292
diverdane pushed a commit that referenced this issue Aug 17, 2021
This change adds the deployment of an application that uses the Secrets
Provider in standalone mode to the E2E application deployment scripts.

This change depends upon PR #373 merging, since PR #373 adds a Helm
subchart for an application that uses Secrets Provider in standalone
mode. There is one line in the `start` script that will need to be
changed after PR #373 has merged in order to enable deployment of
this application.

Addresses Issue #292
@diverdane diverdane self-assigned this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant