Add Helm subchart for test app w/ Secrets Provider in standalone mode #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diverdane
force-pushed
the
add-sp-standalone-helm
branch
4 times, most recently
from
4fa651a to
c42aa87
Compare
diverdane
pushed a commit
that referenced
this pull request
Aug 16, 2021
This change adds the deployment of an application that uses the Secrets Provider in standalone mode to the E2E application deployment scripts. This change depends upon PR #373 merging, since PR #373 adds a Helm subchart for an application that uses Secrets Provider in standalone mode. There is one line in the `start` script that will need to be changed after PR #373 has merged in order to enable deployment of this application. Addresses Issue #292
7 tasks
diverdane
force-pushed
the
add-sp-standalone-helm
branch
from
c42aa87 to
5d9083f
Compare
| @@ -0,0 +1,67 @@ | |||
| suite: test test_app_secrets_provider_init | |||
There was a problem hiding this comment.
suite here points to test_app_secrets_provider_init - assume we'd like test_app_secrets_provider_standalone
There was a problem hiding this comment.
Good catch, thanks! Will fix.
diverdane
force-pushed
the
add-sp-standalone-helm
branch
from
5d9083f to
fcaa935
Compare
diverdane
pushed a commit
that referenced
this pull request
Aug 16, 2021
This change adds the deployment of an application that uses the Secrets Provider in standalone mode to the E2E application deployment scripts. This change depends upon PR #373 merging, since PR #373 adds a Helm subchart for an application that uses Secrets Provider in standalone mode. There is one line in the `start` script that will need to be changed after PR #373 has merged in order to enable deployment of this application. Addresses Issue #292
diverdane
pushed a commit
that referenced
this pull request
Aug 17, 2021
This change adds the deployment of an application that uses the Secrets Provider in standalone mode to the E2E application deployment scripts. This change depends upon PR #373 merging, since PR #373 adds a Helm subchart for an application that uses Secrets Provider in standalone mode. There is one line in the `start` script that will need to be changed after PR #373 has merged in order to enable deployment of this application. Addresses Issue #292
diverdane
pushed a commit
that referenced
this pull request
Aug 17, 2021
This change adds the deployment of an application that uses the Secrets Provider in standalone mode to the E2E application deployment scripts. This change depends upon PR #373 merging, since PR #373 adds a Helm subchart for an application that uses Secrets Provider in standalone mode. There is one line in the `start` script that will need to be changed after PR #373 has merged in order to enable deployment of this application. Addresses Issue #292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change adds a Helm subchart to the
conjur-app-deploymain Helm chart that can be used to deploy:The deployment of the "standalone" Secrets Provider is done by using the Secrets Provider Helm chart as a Helm chart dependency of the
app-secrets-provider-standalonesubchart.This change also includes Helm unittest test cases and Helm schema validation tests for the new subchart.
NOTE: Adding this Helm subchart to the E2E workflow scripts will be done with PR #380.
What ticket does this PR close?
Resolves #273
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, orManual tests
If you are preparing for a release, have you run the following manual tests to verify existing functionality continues to function as expected?