-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore changes from #90, "Refactor PromptUI" #120
Conversation
eb9b078
to
c1b6315
Compare
This reverts commit cd4f278.
e225fd8
to
4be26f3
Compare
Code Climate has analyzed commit fcc14a2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 71.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.4%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing up this branch! Nice workaround to address the unit test delays in the original PR. I also like that it allows us to clean up some of the utils and avoid passing the PromptDecorator func around.
I suggest we hold out for another reviewer to approve since I was heavily involved in the original PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - goodbye decoratePrompt
& setCommandStreamsOnPrompt
!
Bug report details
conjur-cli-go binary displays double prompt on windows terminal.
This may be related to prompt-ui refactor. Does not seem to impact functionality
Steps to reproduce:
conjur init
commandCurrent Results:
results in double prompt
Expected Results:
single prompt
Desired Outcome
Windows displays single prompt
Implemented Changes
Connected Issue/Story
CyberArk internal issue ID: CNJR-475
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security