-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove netgo tag to fix Windows hosts file bug #121
Conversation
CI is failing due to issue that will be fixed when #120 is merged |
.goreleaser.yml
Outdated
flags: | ||
- -tags=netgo | ||
# - -tags=netgo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# - -tags=netgo | |
- -tags={{ if not eq .Os "windows" }}netgo{{ end }} |
Let's apply this exclusion only to Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this template string is the exact thing we want but something to this effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it working with slightly different syntax - ne
instead of not eq
3bd053d
to
8927adc
Compare
c6fb44a
to
63771ad
Compare
Code Climate has analyzed commit 28451db and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.4% (0.0% change). View more on Code Climate. |
Desired Outcome
Conjur CLI should use Windows hosts file when present.
Implemented Changes
netgo
has a bug that prevents it from using the machine's hosts file on Windows. See golang/go#57757.This PR disables the
netgo
build flag. It can be reenabled once the above issue is fixed.Connected Issue/Story
CyberArk internal issue ID: CNJR-904
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security