Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove netgo tag to fix Windows hosts file bug #121

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Remove netgo tag to fix Windows hosts file bug #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,13 @@ builds:
# Tag 'netgo' is a Go build tag that ensures a pure Go networking stack
# in the resulting binary instead of using the default host's stack to
# ensure a fully static artifact that has no dependencies.
# However, netgo on Windows has a bug that prevents it from using the
# machine's hosts file for DNS resolution. Therefore this tag must be
# omitted on Windows until the bug is fixed. See
# https://github.com/golang/go/issues/57757 and internal ticket
# CNJR-904 for more information.
flags:
- -tags=netgo
- -tags={{ if ne .Os "windows" }}netgo{{ end }}
- -a
goos:
- linux
Expand Down
9 changes: 7 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Nothing should go in this section, please add to the latest unreleased version
(and update the corresponding date), or add a new version.

## [8.0.7] - 2023-04-17
## [8.0.7] - 2023-04-18

### Fixed
- Fixed not using hosts file on Windows
[cyberark/conjur-cli-go#121](https://github.com/cyberark/conjur-cli-go/pull/121)

## [8.0.6] - 2023-04-17

Expand Down Expand Up @@ -72,7 +76,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Added
- Placeholder version to capture the reset of the repository

[Unreleased]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.6...HEAD
[Unreleased]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.7...HEAD
[8.0.7]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.6...v8.0.7
[8.0.6]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.5...v8.0.6
[8.0.5]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.4...v8.0.5
[8.0.4]: https://github.com/cyberark/conjur-cli-go/compare/v8.0.3...v8.0.4
Expand Down