Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error message in retrieve variable if variable is empty #2023

Closed
InbalZilberman opened this issue Feb 3, 2021 · 8 comments · Fixed by #2074
Closed

Change error message in retrieve variable if variable is empty #2023

InbalZilberman opened this issue Feb 3, 2021 · 8 comments · Fixed by #2074
Assignees
Labels

Comments

@InbalZilberman
Copy link
Contributor

InbalZilberman commented Feb 3, 2021

As a developer, I want to understand the different reasons for failing to retrieve a Conjur variable , so that I can identify the problem better and resolve the it if needed.

Today when one retrieve a variable and the variable is empty he gets
Variable not found in account
We would like to change only the message to
Variable is empty or not found

GIVEN policy with variable X loaded
WHEN retrieving variable x
THEN return 404 with error message Variable is empty or not found

Developer Notes

  • http code should remain the same
  • code error in the message should remain the same
@InbalZilberman
Copy link
Contributor Author

@alexkalish @izgeri FYI
@liavyona please let me know if you need developer notes added

@liavyona
Copy link

liavyona commented Feb 3, 2021

@InbalZilberman @shulifink @izgeri @alexkalish is the message Variable is empty or not found should be on both cases? I think yes (security wise - we don't want to expose whether a secret exists or not)

@shulifink
Copy link
Contributor

not sure about security issues etc, but the English is fine.

@InbalZilberman
Copy link
Contributor Author

@liavyona what is the status of this bug?
Is there a PR that is linked to it?

@sashaCher
Copy link
Contributor

@liavyona Role that has execute permissions on the variable can see that the variable is empty (exactly as it can see the variable value).

@InbalZilberman
Copy link
Contributor Author

@sashaCher I think the remark you made should be addressed to @shulifink who asked if this is a security issue

@shulifink
Copy link
Contributor

@sashaCher @InbalZilberman - I was not asking about the security issue.
I was just saying that the english is fine and that I don't know anything about what in in brackets... but the english is fine. If everyone else is happy with what @liavyona wrote in brackets, the I am too. :)

@InbalZilberman
Copy link
Contributor Author

@liavyona all approved we can go on

izgeri pushed a commit to cyberark/secretless-broker that referenced this issue Apr 7, 2021
We are testing the log message and the error changed on the server side in
cyberark/conjur#2023. This updates the expected message.
izgeri pushed a commit to cyberark/secretless-broker that referenced this issue Apr 7, 2021
We are testing the log message and the error changed on the server side in
cyberark/conjur#2023. This updates the expected message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants