Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the code string of secret not found error #2092

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

liavyona
Copy link

@liavyona liavyona commented Mar 30, 2021

What does this PR do?

Align the fetching empty or missing secret code string with the rest of the API.

This is a fix to go with the changes from #2023

@liavyona liavyona requested a review from a team as a code owner March 30, 2021 14:01
@liavyona liavyona requested a review from orenbm March 30, 2021 14:01
Copy link
Contributor

@izgeri izgeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented Mar 30, 2021

Code Climate has analyzed commit d357927 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.4% (0.0% change).

View more on Code Climate.

@liavyona liavyona merged commit 90933ef into master Mar 30, 2021
@liavyona liavyona deleted the fix-missing-secret-code branch March 30, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants