Delete secrets files when retrieval fails #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szh
changed the title
szh
force-pushed
the
delete-file-if-revoked
branch
from
b519ffe to
fc3dc3d
Compare
szh
force-pushed
the
delete-file-if-revoked
branch
10 times, most recently
from
75cf39e to
436b1ac
Compare
diverdane
reviewed
Mar 11, 2022
deploy/test/test_in_docker.sh
Outdated
| @@ -5,6 +5,9 @@ set -xeuo pipefail | |||
|
|
|||
| # Clean up when script completes and fails | |||
| finish() { | |||
| dump_conjur_namespace_upon_error | |||
There was a problem hiding this comment.
Thank you for putting this in!!!!
There was a problem hiding this comment.
I ended up removing it because I was getting "kubectl: command not found" errors... Not sure what that's about but I don't want it to hold this up.
There was a problem hiding this comment.
Ah, yeah, the 'kubectl' commands would need to be run via a test client container.
szh
force-pushed
the
delete-file-if-revoked
branch
13 times, most recently
from
a1f59e3 to
2a890a2
Compare
szh
force-pushed
the
delete-file-if-revoked
branch
3 times, most recently
from
578f0cd to
3a0e82d
Compare
szh
force-pushed
the
delete-file-if-revoked
branch
from
3a0e82d to
231ac94
Compare
|
Code Climate has analyzed commit 231ac94 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.0% (-3.7% change). View more on Code Climate. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Delete secret file if Conjur returns a 403 or 404 status code.
Implemented Changes
When secrets rotation is enabled, if a batch fetch call to Conjur fails during a refresh due to a deleted secret or revoked access, delete the secrets files from the shared volume to avoid leaving unauthorized secrets on the file system. Currently there's no support for specifying which secret(s) failed, so we need to delete all secrets included in the fetch, which includes all secret groups. A future effort will improve this.
This feature can be disabled using an annotation,
conjur.org/remove-deleted-secrets-enabled: "false".Connected Issue/Story
CyberArk internal issue link: ONYX-17938
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security