Set updated status when sanitizing secrets #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
When a secret retrieval operation fails with a 403 or 404 error, we remove the stored secrets. See #447, #449
This PR changes the behavior of the status reporter (added in #450) to report a successful update when this sanitization occurs, even though an error is also returned. This way the consuming application will know that the secrets have changed.
TODO: Do we need integration tests to ensure the sentinel files are being created?
Connected Issue/Story
N/A
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security