Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set updated status when sanitizing secrets #458

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

szh
Copy link
Contributor

@szh szh commented Apr 5, 2022

Desired Outcome

When a secret retrieval operation fails with a 403 or 404 error, we remove the stored secrets. See #447, #449
This PR changes the behavior of the status reporter (added in #450) to report a successful update when this sanitization occurs, even though an error is also returned. This way the consuming application will know that the secrets have changed.

TODO: Do we need integration tests to ensure the sentinel files are being created?

Connected Issue/Story

N/A

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Apr 5, 2022
@szh szh force-pushed the updated-after-clearing branch 2 times, most recently from 4737753 to 0094384 Compare April 5, 2022 17:40
@szh szh marked this pull request as ready for review April 5, 2022 17:41
@szh szh requested a review from a team as a code owner April 5, 2022 17:41
@szh szh force-pushed the updated-after-clearing branch from 0094384 to c6a4400 Compare April 6, 2022 20:04
@szh szh force-pushed the updated-after-clearing branch from c6a4400 to 42977aa Compare April 7, 2022 13:08
@codeclimate
Copy link

codeclimate bot commented Apr 7, 2022

Code Climate has analyzed commit 42977aa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.2% (0.2% change).

View more on Code Climate.

Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@szh szh merged commit 49451e8 into main Apr 8, 2022
@szh szh deleted the updated-after-clearing branch April 8, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants