Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace optparse with argparse and target higher python versions for tests #193

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Replace optparse with argparse and target higher python versions for tests #193

merged 2 commits into from
Nov 14, 2022

Conversation

ad-daniel
Copy link
Contributor

As mentioned here cyberbotics/webots_ros2#515

  • Replace optparse with argparse (has been deprecated)
  • Since python 3.5 and 3.6 have reached their end of life, the test now only favors higher versions.

@ad-daniel ad-daniel added the bug Something isn't working label Nov 14, 2022
@ad-daniel ad-daniel self-assigned this Nov 14, 2022
@ad-daniel ad-daniel marked this pull request as ready for review November 14, 2022 10:15
ygoumaz
ygoumaz approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@ygoumaz ygoumaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! As discussed we should now:

  1. Create a new release of urdf2webots.
  2. Synchronize the submodule on the webots_ros2 side
  3. Fix the same problem in webots_ros2 (master branch)
  4. Synchronize master and develop on webots_ros2.

@ad-daniel ad-daniel merged commit 15beadc into master Nov 14, 2022
@ad-daniel ad-daniel deleted the fix-optparse-error branch November 14, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygoumaz ygoumaz ygoumaz approved these changes

Assignees

@ad-daniel ad-daniel

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ad-daniel @ygoumaz