Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert E-puck name to e-puck #587

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Revert E-puck name to e-puck #587

merged 4 commits into from
Jan 5, 2023

Conversation

ygoumaz
Copy link
Contributor

@ygoumaz ygoumaz commented Jan 4, 2023

#574 fixed the name from e-puck to epuck in the rats life example.

To be consistent with the default name of the E-puck, this PR reverts the change and modifies the name from epuck to e-puck in the launcher and the epuck_world instead.

@ygoumaz ygoumaz added the cleanup label Jan 4, 2023
@ygoumaz ygoumaz marked this pull request as ready for review January 5, 2023 09:28
@ygoumaz ygoumaz requested a review from omichel January 5, 2023 09:28
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test that the service names published by ROS are working fine with the dash in the robot name?

@ad-daniel
Copy link
Contributor

In theory names are sanitized here:

std::string robotName(wb_robot_get_name());
for (char notAllowedChar : " -.)(")
std::replace(robotName.begin(), robotName.end(), notAllowedChar, '_');

@ygoumaz
Copy link
Contributor Author

ygoumaz commented Jan 5, 2023

Yes I tested and it works fine. Dashes are replaced by underscores.

@ygoumaz ygoumaz merged commit a5f21ca into master Jan 5, 2023
@ygoumaz ygoumaz deleted the fix-epuck-name branch January 5, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants