-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change spawn command name. #3816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not changed the internal method names that action this command, just the user-facing stuff
👍
Without re-creating the virtual environment, cylc spawn
gives some Python traceback due to missing module. But after re-creating it, it prints the expected output
(venv) kinow@ranma:~/Development/python/workspace/cylc-flow$ cylc spawn
Error: cylc spawn: unknown utility. Abort.
Type "cylc help all" for a list of utilities.
Also did a grep with IDE, found no occurrences of anything similar to cylc spawn
. Great job!
Q: is REG
an argument? The usage example doesn't seem to use it. Asking because I'm trying to run a simple test with five
😬
Good spotting! REG stands for "REGistered workflow name" (i.e. from (I'll also put an issue up to swap out "REG" for something less obscure, probably "FLOW", in all command help). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & working on my machine, tests passed, code LGTM 👍
These changes close #3735
After discussion on the Issue and in offline chat, I've gone with
cylc set-outputs
as the new command name. This should be a more intuitively obvious name for users (it makes the scheduler behave just as if specified outputs had been completed naturally).Notes:
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.