Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: rename spawn -> set-outputs #3821

Merged
merged 1 commit into from
Sep 16, 2020
Merged

cli: rename spawn -> set-outputs #3821

merged 1 commit into from
Sep 16, 2020

Conversation

oliver-sanders
Copy link
Member

Catch a few spawn references missed in #3816.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • No dependency changes.

@oliver-sanders oliver-sanders added this to the cylc-8.0a3 milestone Sep 16, 2020
@oliver-sanders oliver-sanders self-assigned this Sep 16, 2020
dwsutherland
dwsutherland approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍 .. I'll rebase #3757 after merging this..

@dwsutherland dwsutherland merged commit 49601fe into cylc:master Sep 16, 2020
hjoliver
hjoliver reviewed Sep 16, 2020
View reviewed changes
cylc/flow/scripts/cylc_help.py
@@ -238,7 +238,7 @@ def category_help(category):
control_commands['kill'] = ['kill']
control_commands['hold'] = ['hold']
control_commands['release'] = ['release', 'unhold']
control_commands['spawn'] = ['spawn']
control_commands['set-outputs'] = ['set-outpus']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, spelling error! I'll push up a hot fix, not worth a PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Found post merge).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍌

@oliver-sanders oliver-sanders deleted the spawn-rename-to-set-outputs branch September 17, 2020 10:58
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver left review comments

@dwsutherland dwsutherland dwsutherland approved these changes

@kinow kinow kinow approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.
4 participants
@oliver-sanders @kinow @hjoliver @dwsutherland