chore: apply ux feedback #19286
Merged
chore: apply ux feedback #19286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
pstakoun
reviewed
Dec 7, 2021
| @@ -174,8 +174,8 @@ | |||
| "bodySuccess": "You are now logged in as {0}.", | |||
| "bodyError": "An error occurred while attempting to log in:", | |||
| "bodyBrowserError": "Cypress was unable to open your installed browser. To continue logging in, please paste this URL into your web browser:", | |||
| "dashboard": "Cypress Dashboard Service", | |||
| "titleInitial": "Log In To Cypress", | |||
| "cloud": "Cypress Cloud Service", | |||
There was a problem hiding this comment.
Are we using "Cloud" in this release? I think this is still very much up in the air and may cause confusion if we haven't changed this verbiage throughout services before releasing this.
marktnoonan
approved these changes
Dec 7, 2021
marktnoonan
requested changes
Dec 7, 2021
marktnoonan
previously approved these changes
Dec 21, 2021
|
I made minor changes to have consistent fonts in the header and resolve some conflicts where @ZachJW34 had made changes that overlapped. |
tgriesser
added a commit
that referenced
this pull request
Dec 22, 2021
…cycle * 10.0-release: chore: apply ux feedback (#19286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?